Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: throw exception from async request when there's a connection iss… #16

Merged
merged 1 commit into from
Jul 27, 2023
Merged

fix: throw exception from async request when there's a connection iss… #16

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions src/Services/BaseService.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -103,9 +103,13 @@ public function request(
if ($rsOptions?->manuallyHandleRequestErrors) {
// Execute as a promise so an exception is not thrown from PendingRequest
// when the request fails
// However this will throw exceptions for an invalid request body, or connection issues
$response = $request->async()
->send($method, $url, $options)
->then(function ($response) use ($rsOptions) {
if ($response instanceof \Throwable) {
throw $response;
}
$this->handleErrors($response, $rsOptions);
return $response;
})->wait();
Expand Down