Skip to content
This repository has been archived by the owner on Jan 27, 2025. It is now read-only.

CM-971: Rename trackerName to trackerVersion #289

Merged
merged 3 commits into from
Jan 8, 2024
Merged

CM-971: Rename trackerName to trackerVersion #289

merged 3 commits into from
Jan 8, 2024

Conversation

wi101
Copy link
Contributor

@wi101 wi101 commented Dec 21, 2023

The trackerName is confusing.

Related PR:

Author Todo List:

  • Add/adjust tests (if applicable)
  • Build in CI passes
  • Latest master revision is merged into the branch
  • Self-Review
  • Set Ready For Review status

@wi101 wi101 requested a review from a team as a code owner December 21, 2023 12:55
@wi101 wi101 marked this pull request as draft December 21, 2023 13:19
@wi101 wi101 self-assigned this Dec 21, 2023
@wi101 wi101 marked this pull request as ready for review December 21, 2023 15:39
@wi101 wi101 requested a review from a team January 2, 2024 09:25
@@ -8,8 +8,8 @@
- contains the b64 url encoded string of the JSON that was sent via `liveConnect.push` function
### `duid`
- contains the LiveConnect managed first party identifier, in the `${apexDomainHash}--${ULID}`
### `tna`
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm fine with the change. But given that we need to maintain backwards compat, I'm not sure this will be any less confusing

@wi101 wi101 merged commit 38a8637 into master Jan 8, 2024
3 checks passed
@wi101 wi101 deleted the cm-971 branch January 8, 2024 17:15
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants