-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(widgets): ✨ Add Uptime Kuma Widget #1501
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
✅ Deploy Preview for dashy-dev ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @imjimmeh
All looks great, except I think your editor has auto-modified all of the widgets.md file, which is causing some conflicts.
I'm happy to update that so it only includes your addition, and the rest of the content remains untouched, if you need.
Damn auto format... Think I fixed it if you wouldn't mind having a peruse? |
Ah piss. Just noticed I somehow deleted some section? Might have reverted back a commit too far. I'll fix it later tonight, unless you want to sort it out if you have time before I get to it 😄 |
No worries, I've added that back in :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
Category:
Feature/new widget (and documentation to match)
Overview
There is more code to display whether the certificate is valid or not, and when the certificate expires, but I'm a terrible designer so I left those for now.
I've tried to use existing styling where possible, but again I am not a designer.
Code Quality Checklist (Please complete)
- [ ] (If a new config option is added) Attribute is outlined in the schema and documentedN/A- [ ] (If a new dependency is added) Package is essential, and has been checked out for security or performanceN/AIf there's any changes you'd request making please feel free.