Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(widgets): ✨ Add Uptime Kuma Widget #1501

Merged
merged 10 commits into from
Mar 9, 2024

Conversation

imjimmeh
Copy link
Contributor

@imjimmeh imjimmeh commented Mar 6, 2024

imjimmeh Medium imjimmeh /feat/uptime-kuma-widget → Lissy93/dashy Commits: 10 | Files Changed: 3 | Additions: 292 Label Unchecked Tasks Powered by Pull Request Badge

Category:

Feature/new widget (and documentation to match)

Overview

  • Adds a widget for basic Uptime Kuma statistics
  • Currently supports:
  1. Status (up/down)
  2. Response time

There is more code to display whether the certificate is valid or not, and when the certificate expires, but I'm a terrible designer so I left those for now.

image

I've tried to use existing styling where possible, but again I am not a designer.

Code Quality Checklist (Please complete)

  • All changes are backwards compatible
  • All lint checks and tests are passing
  • There are no (new) build warnings or errors
    - [ ] (If a new config option is added) Attribute is outlined in the schema and documented N/A
    - [ ] (If a new dependency is added) Package is essential, and has been checked out for security or performance N/A
  • Bumps version, if new feature added Do you count a new widget as a feature/version bump? I have not touched the version FWIW

If there's any changes you'd request making please feel free.

@imjimmeh imjimmeh requested a review from Lissy93 as a code owner March 6, 2024 19:07
Copy link

vercel bot commented Mar 6, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
dashy ❌ Failed (Inspect) Mar 9, 2024 10:08pm

@imjimmeh imjimmeh changed the title ✨: Add Uptime Kuma Widget feat(widgets): ✨ Add Uptime Kuma Widget Mar 6, 2024
Copy link

netlify bot commented Mar 6, 2024

Deploy Preview for dashy-dev ready!

Name Link
🔨 Latest commit 828f25d
🔍 Latest deploy log https://app.netlify.com/sites/dashy-dev/deploys/65ecddcb8105630008c27612
😎 Deploy Preview https://deploy-preview-1501--dashy-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@liss-bot liss-bot added the 🚫 Merge Conflicts [PR] Submitted code needs rebasing label Mar 6, 2024
Copy link
Owner

@Lissy93 Lissy93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @imjimmeh
All looks great, except I think your editor has auto-modified all of the widgets.md file, which is causing some conflicts.

I'm happy to update that so it only includes your addition, and the rest of the content remains untouched, if you need.

@imjimmeh
Copy link
Contributor Author

imjimmeh commented Mar 8, 2024

Damn auto format...

Think I fixed it if you wouldn't mind having a peruse?

@imjimmeh
Copy link
Contributor Author

imjimmeh commented Mar 8, 2024

Ah piss. Just noticed I somehow deleted some section? Might have reverted back a commit too far.

I'll fix it later tonight, unless you want to sort it out if you have time before I get to it 😄

@Lissy93
Copy link
Owner

Lissy93 commented Mar 9, 2024

Ah piss. Just noticed I somehow deleted some section? Might have reverted back a commit too far.
I'll fix it later tonight, unless you want to sort it out if you have time before I get to it 😄

No worries, I've added that back in :)

Copy link
Owner

@Lissy93 Lissy93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@Lissy93 Lissy93 removed the 🚫 Merge Conflicts [PR] Submitted code needs rebasing label Mar 9, 2024
@Lissy93 Lissy93 merged commit 8371218 into Lissy93:master Mar 9, 2024
7 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants