Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Ukrainian language #1300

Merged
merged 2 commits into from
Aug 27, 2023
Merged

Feature: Ukrainian language #1300

merged 2 commits into from
Aug 27, 2023

Conversation

allozavrr
Copy link
Contributor

@allozavrr allozavrr commented Aug 26, 2023

allozavrr Medium allozavrr /master → Lissy93/dashy Commits: 2 | Files Changed: 2 | Additions: 453 Powered by Pull Request Badge

Thank you for contributing to Dashy! So that your PR can be handled effectively, please populate the following fields (delete sections that are not applicable)

Category:

One of: Bugfix / Feature / Code style update / Refactoring Only / Build related changes / Documentation / Other (please specify)

Overview

Briefly outline your new changes...

  1. Add @/assets/locales/ua.json

  2. Add Ukrainian language in @/srs/utils/languages.js

Issue Number (if applicable) #00

New Vars (if applicable)

Fix @/srs/utils/languages.js

Screenshot (if applicable)

If you've introduced any significant UI changes, please include a screenshot

Code Quality Checklist (Please complete)

  • [☑️] All changes are backwards compatible
  • [☑️] All lint checks and tests are passing
  • [☑️] There are no (new) build warnings or errors
  • [☑️] (If a new config option is added) Attribute is outlined in the schema and documented
  • [☑️] (If a new dependency is added) Package is essential, and has been checked out for security or performance
  • [] Bumps version, if new feature added

@allozavrr allozavrr requested a review from Lissy93 as a code owner August 26, 2023 07:17
@netlify
Copy link

netlify bot commented Aug 26, 2023

Deploy Preview for dashy-dev ready!

Name Link
🔨 Latest commit 344a109
🔍 Latest deploy log https://app.netlify.com/sites/dashy-dev/deploys/64eb37d6ef5667000778abcc
😎 Deploy Preview https://deploy-preview-1300--dashy-dev.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@viezly
Copy link

viezly bot commented Aug 26, 2023

Changes preview:

Legend:

👀 Review pull request on Viezly

Copy link
Owner

@Lissy93 Lissy93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thank you @allozavrr 🙌 🇺🇦💖

"css-note-label": "Примітка",
"css-note-l1": "Вам потрібно буде оновити сторінку, щоб ваші зміни набули чинності.",
"css-note-l2": "Заміни стилів зберігаються лише локально, тому рекомендується зробити копію вашого CSS.",
"css-note-l3": "Щоб видалити всі спеціальні стилі, видаліть вміст та натисніть "Зберегти зміни"",
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like you've got an extra " here, which is making it invalid JSON

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Replace with this, and we should be good to go :)

- "css-note-l3": "Щоб видалити всі спеціальні стилі, видаліть вміст та натисніть "
-		Зберегти зміни "",
+ "css-note-l3": "Щоб видалити всі спеціальні стилі, видаліть вміст та натисніть Зберегти зміни",

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually was only a quick change, so I've updated it in 344a109 :)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @Lissy93 and sorry for my mistake. Have a great day 🥰

@Lissy93 Lissy93 merged commit 4786020 into Lissy93:master Aug 27, 2023
@liss-bot
Copy link
Collaborator

liss-bot commented Mar 3, 2024

The fix for this issue has now been released in 2.1.2 ✨

If you haven't done so already, please update your instance to 2.1.2 or later. See 2.1.2 for full info.

Feel free to reach out if you need any more support. If you are enjoying Dashy, consider supporting the project.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants