Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added Mvg Widget #1047

Merged
merged 5 commits into from
Jan 23, 2023
Merged

Added Mvg Widget #1047

merged 5 commits into from
Jan 23, 2023

Conversation

m42e
Copy link
Contributor

@m42e m42e commented Jan 8, 2023 •
edited by pull-request-badge bot
Loading

m42e ✨ Feature Large m42e /mvg-upstream → Lissy93/dashy Commits: 5 | Files Changed: 5 | Additions: 816 Unchecked Tasks

Display mvg departure times for MVG station.

Category: Feature

Overview
Display The departure times of the next public transportation for Munich.

New Vars (if applicable)

Field Type Required Description
location string Required The name of the location (exact) or the location id, startin with de:09162:
limit integer Optional Limit number of entries, defaults to 10.

defaults.mvg

Screenshot

Mvg list of departures

Code Quality Checklist (Please complete)

  • All changes are backwards compatible
  • All lint checks and tests are passing
  • There are no (new) build warnings or errors
  • (If a new config option is added) Attribute is outlined in the schema and documented
  • Bumps version, if new feature added ?

@m42e m42e requested a review from Lissy93 as a code owner January 8, 2023 18:14
@netlify
Copy link

netlify bot commented Jan 8, 2023 •
edited
Loading

✅ Deploy Preview for dashy-dev ready!

Name Link
🔨 Latest commit 59118a5
🔍 Latest deploy log https://app.netlify.com/sites/dashy-dev/deploys/63cd70e4f0027b0009e86a7b
😎 Deploy Preview https://deploy-preview-1047--dashy-dev.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@viezly
Copy link

viezly bot commented Jan 8, 2023 •
edited
Loading

Changes preview:

Legend:

👀 Review pull request on Viezly

@m42e
Added Mvg Widget
b404bb0 
Display mvg departure times for MVG station.
Lissy93
Lissy93 approved these changes Jan 22, 2023
View reviewed changes
Copy link
Owner

@Lissy93 Lissy93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great :)

Are you ready for me to go ahead and merge?

@Lissy93 Lissy93 added the ✨ New Feature [PR] Contains implementation of a new feature label Jan 22, 2023
@m42e
Copy link
Contributor Author

m42e commented Jan 22, 2023

Yes, you can go ahead.

@Lissy93 Lissy93 merged commit 18c2af7 into Lissy93:master Jan 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Lissy93 Lissy93 Lissy93 approved these changes

Assignees
No one assigned
Labels
✨ New Feature [PR] Contains implementation of a new feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@m42e @Lissy93