Skip to content

Commit

Permalink
Update mac build method
Browse files Browse the repository at this point in the history
  • Loading branch information
shuse2 committed May 19, 2024
1 parent 3331d78 commit c0f52cc
Show file tree
Hide file tree
Showing 2 changed files with 9 additions and 12 deletions.
19 changes: 8 additions & 11 deletions .github/workflows/electron-build.yml
Original file line number Diff line number Diff line change
Expand Up @@ -47,17 +47,16 @@ jobs:
run: |
aws s3 sync s3://lisk-desktop-files/fonts ./setup/react/assets/fonts/
- name: Update package.json
if: startsWith(matrix.os, 'macos')
run: |
jq '.build.mac.notarize.teamId = "${{ secrets.APPLE_TEAM_ID }}"' package.json > package_temp.json
mv package_temp.json package.json
- name: Install cpx
if: startsWith(matrix.os, 'desktop-build')
run: npm install -g cpx

- name: Prepare for app notarization
if: startsWith(matrix.os, 'macos')
# Import Apple API key for app notarization on macOS
run: |
mkdir -p ~/private_keys/
echo "${{ secrets.api_key_new }}" > ~/private_keys/AuthKey_${{ secrets.api_key_id_new }}.p8
- name: Build and pack windows app
if: startsWith(matrix.os, 'desktop-build')
# codesigning
Expand All @@ -76,10 +75,8 @@ jobs:
github_token: ${{ secrets.github_token }}
env:
# macOS for notarization API key
API_KEY: ${{ secrets.api_key_new }}
API_KEY_ID: ${{ secrets.api_key_id_new }}
API_KEY_ISSUER_ID: ${{ secrets.api_key_issuer_id }}
APPLE_TEAM_ID: ${{ secrets.apple_team_id }}
APPLE_ID: ${{ secrets.APPLE_ID }}
APPLE_APP_SPECIFIC_PASSWORD: ${{ secrets.APPLE_APP_SPECIFIC_PASSWORD }}

- name: Output Notarization Error Log
if: failure() && startsWith(matrix.os, 'macos')
Expand Down
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -84,7 +84,7 @@
"entitlements": "build/entitlements.plist",
"entitlementsInherit": "build/entitlements.plist",
"notarize": {
"teamId": "${APPLE_TEAM_ID}"
"teamId": ""
},
"target": {
"target": "default",
Expand Down

0 comments on commit c0f52cc

Please sign in to comment.