Resolves warnings from slither #190
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… warnings disables unchecked-transfer rule for all calls to IL2LiskToken.transferFrom in L2Reward disables unused-return rule for all calls to IL2LiskToken.approve in L2Reward disables unused-return rule for all calls to Math.trySub in L2Reward disables reentrancy-no-eth for L2Reward._delePosition disables reentrancy-no-eth for L2Reward._initiateFastUnlock resolves warnings in L2Reward.createPosition disables uninitialized-state for L2LockingPosition.lockingPosition state variable
matjazv
requested changes
Jul 3, 2024
matjazv
approved these changes
Jul 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was the problem?
This PR resolves #182
How was it solved?
Modifies L2Reward and L2LockingPosition to supress or resolve slither warnings;
How was it tested?
N/A