Skip to content
This repository was archived by the owner on Feb 17, 2021. It is now read-only.

#188: No event called after tour is finished #194

Merged
merged 1 commit into from
Jul 20, 2015
Merged

#188: No event called after tour is finished #194

merged 1 commit into from
Jul 20, 2015

Conversation

kate2753
Copy link
Contributor

This pull request resolves #188 . Summary of changes:

  • Ending tour when we are on the last step
  • Add unit test to test this case
  • Update all unit tests to use Jasmine spies instead of adding a class to the body element
  • Make sure we clear state after each test by ending tour and removing all callouts
  • Center test markup, so we can actually see HopscotchBubble while testing\debugging

@kate2753 kate2753 changed the title [GH-188] No event called after tour is finished #188 No event called after tour is finished Jun 26, 2015
@kate2753 kate2753 changed the title #188 No event called after tour is finished #188: No event called after tour is finished Jun 26, 2015
kate2753 added a commit that referenced this pull request Jul 20, 2015
@kate2753
Merge pull request #194 from kate2753/gh188
71b46a1 
#188: No event called after tour is finished
@kate2753 kate2753 merged commit 71b46a1 into LinkedInAttic:master Jul 20, 2015
@kate2753 kate2753 deleted the gh188 branch July 21, 2015 19:56
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

No event called after tour is finished
2 participants
@kate2753 @timlindvall