Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make Viewer extendable #453

Closed
walterxie opened this issue Apr 2, 2024 · 2 comments
Closed

Make Viewer extendable #453

walterxie opened this issue Apr 2, 2024 · 2 comments
Labels
critical change the bug fix or new feature will significant change the code enhancement New feature or request

Comments

@walterxie
Copy link
Collaborator

Make Viewer extendable through SPI, so that the ViewerRegister can register the extended Viewer from another lphy extension.
@walterxie walterxie added the enhancement New feature or request label Apr 2, 2024
walterxie added a commit that referenced this issue Apr 3, 2024
@walterxie
Create SPI to make Viewer extendable, and improve SequenceTypeExtensi…
77a95d5 
…on message #453
walterxie added a commit that referenced this issue Apr 3, 2024
@walterxie
correct viewer name #453
0e78c27
@walterxie walterxie added the critical change the bug fix or new feature will significant change the code label Apr 3, 2024
walterxie added a commit that referenced this issue Apr 3, 2024
@walterxie
export required packages #453
d4a216c
walterxie added a commit that referenced this issue Apr 3, 2024
@walterxie
change viewerList to protected #453
265069c
walterxie added a commit to yxu927/PopSizeFunc that referenced this issue Apr 4, 2024
@walterxie
create extendable Viewer for lphy extension, popsizefunc LinguaPhylo/…
2c44b44 
…linguaPhylo#453
@walterxie
Copy link
Collaborator Author

walterxie commented Apr 4, 2024 •
edited
Loading

TODO : The list should change to Map<T, Viewer> where T is the class, e.g. Alignment, Double, ...

Then addViewers can check if viewer for a type already exists, after getViewers() changes to Map<T, Viewer>.

walterxie added a commit that referenced this issue Apr 4, 2024
@walterxie
add comments and TODO #453
f4b43a5
walterxie added a commit that referenced this issue Apr 4, 2024
@walterxie
Simplify the Viewer SPI #453 #454
108c88b
@walterxie
Copy link
Collaborator Author

#454

walterxie added a commit that referenced this issue Apr 4, 2024
@walterxie
for deploying service providers on the class path #453 #454
89370e7
walterxie added a commit that referenced this issue Apr 4, 2024
@walterxie
create services for the usage of class path, and add notes #453 #454
a1141ed
walterxie added a commit to yxu927/PopSizeFunc that referenced this issue Apr 5, 2024
@walterxie
better SPI for Viewer in the lphy extension (popsizefunc) LinguaPhylo…
b04331c 
…/linguaPhylo#453
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
critical change the bug fix or new feature will significant change the code enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@walterxie