Use logging.exception to log stacktrace (kubeflow#151)

* Use logging.exception to log stacktrace * update
Linchin · Jun 6, 2018 · fe1c2d4 · fe1c2d4
1 parent f0aaa5e
commit fe1c2d4
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 8 deletions.
diff --git a/py/kubeflow/testing/run_e2e_workflow.py b/py/kubeflow/testing/run_e2e_workflow.py
@@ -203,11 +203,11 @@ def run(args, file_handler): # pylint: disable=too-many-statements,too-many-bran
       logging.info("Workflow %s/%s finished phase: %s", get_namespace(args), name, phase)
   except util.TimeoutError:
     success = False
-    logging.error("Time out waiting for Workflows %s to finish", ",".join(workflow_names))
+    logging.exception("Time out waiting for Workflows %s to finish", ",".join(workflow_names))
   except Exception as e:
     # We explicitly log any exceptions so that they will be captured in the
     # build-log.txt that is uploaded to Gubernator.
-    logging.error("Exception occurred: %s", e)
+    logging.exception("Exception occurred: %s", e)
     raise
   finally:
     success = prow_artifacts.finalize_prow_job(args.bucket, success, workflow_phase, ui_urls)

diff --git a/py/kubeflow/testing/test_helper.py b/py/kubeflow/testing/test_helper.py
@@ -95,11 +95,11 @@ def wrap_test(test_case):
   try:
     test_case.test_func(test_case)
   except subprocess.CalledProcessError as e:
-    logging.error("Subprocess failed;\n%s", e.output)
+    logging.exception("Subprocess failed;\n%s", e.output)
     test_case.add_failure_info("Subprocess failed;\n{0}".format(e.output))
     raise
   except Exception as e:
-    logging.error("Test failed; %s", e.message)
+    logging.exception("Test failed; %s", e.message)
     test_case.add_failure_info("Test failed; " + e.message)
     raise
   finally:

diff --git a/py/kubeflow/testing/util.py b/py/kubeflow/testing/util.py
@@ -171,8 +171,8 @@ def create_cluster(gke, project, zone, cluster_request):
     logging.info("Cluster creation done.\n %s", create_op)
 
   except errors.HttpError as e:
-    logging.error("Exception occured creating cluster: %s, status: %s", e,
-                  e.resp["status"])
+    logging.exception("Exception occured creating cluster: %s, status: %s", e,
+                      e.resp["status"])
     # Status appears to be a string.
     if e.resp["status"] == '409':
       pass
@@ -200,8 +200,8 @@ def delete_cluster(gke, name, project, zone):
     logging.info("Cluster deletion done.\n %s", delete_op)
 
   except errors.HttpError as e:
-    logging.error("Exception occured deleting cluster: %s, status: %s", e,
-                  e.resp["status"])
+    logging.exception("Exception occured deleting cluster: %s, status: %s", e,
+                      e.resp["status"])
 
 
 def wait_for_operation(client,