-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[JPA2] 이혜원 #22
Open
icegosimperson
wants to merge
10
commits into
Likelion-YeungNam-Univ:main
Choose a base branch
from
icegosimperson:jpa2-assignment
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
[JPA2] 이혜원 #22
icegosimperson
wants to merge
10
commits into
Likelion-YeungNam-Univ:main
from
icegosimperson:jpa2-assignment
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tentennball
reviewed
May 30, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
드디어 코드를 보게 되네요..ㅎㅎ 코드 MVC 잘지켜서 잘짜신것 같아요!! 코드 잘보고 갑니다!!
User user = userRepository.findById(userId) | ||
.orElseThrow(() -> new IllegalArgumentException("해당 유저 없음")); | ||
|
||
user.update(user.getUsername(), pwdDto.newPassword()); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
해당 메서드의 기능은 유저이름, 비밀번호를 업데이트 하는 메서드이니까,, user엔티티에 비밀번호 변경만 해주는 메서드가 따로 있어야 할것 같긴 해요!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
내가 개발한 기능
내가 개발할 때 유의깊게 개발한 부분
내가 개발하면서 들었던 의문 사항
리뷰어가 중점적으로 확인해야하는 부분
테스트 코드X, 기능 구현 Postman 구현 기능 첨부
User 비밀번호 재설정 (rest-pwd)한 뒤, 유저 조회
Post 검색 기능 : 제목
Post 검색 기능 : 내용
Post 검색 기능 : 작성자
Comment 좋아요
Comment 좋아요 취소