Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: make e2e test with address queue updates concurrent #872

Merged
merged 5 commits into from
Jun 27, 2024
Merged

fix: make e2e test with address queue updates concurrent #872

merged 5 commits into from
Jun 27, 2024

Conversation

ananas-block
Copy link
Contributor

@ananas-block ananas-block commented Jun 26, 2024 •
edited
Loading

Issue:

  • address queue concurrency was untested onchain and did not work

Changes:

  • replace BoundedVec in IndexedChangelogEntry with fixed size array
  • introduce a new const generic NET_HEIGHT = HEIGHT - CANOPY_DEPTH to describe the size of IndexedChangelogEntry
  • adapt e2e tests to test address Merkle tree concurrency
  • stopped using clone_from in patch element and proof since it changes the capacity of BoundedVec

@ananas-block ananas-block force-pushed the jorrit/chore-change-e2e-test-params branch from 5c7a99b to be1aef6 Compare June 26, 2024 22:30
@ananas-block ananas-block marked this pull request as ready for review June 26, 2024 22:35
@ananas-block ananas-block requested a review from vadorovsky as a code owner June 26, 2024 22:35
@ananas-block ananas-block force-pushed the jorrit/chore-change-e2e-test-params branch 2 times, most recently from 9baf945 to 8077caf Compare June 26, 2024 22:51
@ananas-block ananas-block force-pushed the jorrit/chore-change-e2e-test-params branch from 8077caf to 15a51cd Compare June 26, 2024 23:33
@ananas-block ananas-block mentioned this pull request Jun 27, 2024
Merged
@vadorovsky vadorovsky changed the title chore: make e2e test with address queue updates concurrent fix: make e2e test with address queue updates concurrent Jun 27, 2024
@vadorovsky vadorovsky merged commit fd604c2 into main Jun 27, 2024
15 checks passed
@vadorovsky vadorovsky deleted the jorrit/chore-change-e2e-test-params branch June 27, 2024 09:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vadorovsky vadorovsky vadorovsky approved these changes

@sergeytimoshin sergeytimoshin Awaiting requested review from sergeytimoshin sergeytimoshin is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ananas-block @vadorovsky