refactor: move PhotonIndexer to light-client crate #1525
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comment on lines
250
to
255
| fn decode_hash(account: &str) -> [u8; 32] { | ||
| let bytes = bs58::decode(account).into_vec().unwrap(); | ||
| let mut arr = [0u8; 32]; | ||
| arr.copy_from_slice(&bytes); | ||
| arr | ||
| } |
There was a problem hiding this comment.
The following avoids the vector allocation. (Just a suggestion below didn't test it.)
Suggested change
| fn decode_hash(account: &str) -> [u8; 32] { | |
| let bytes = bs58::decode(account).into_vec().unwrap(); | |
| let mut arr = [0u8; 32]; | |
| arr.copy_from_slice(&bytes); | |
| arr | |
| } | |
| fn decode_hash(account: &str) -> [u8; 32] { | |
| let mut arr = [0u8; 32]; | |
| bs58::decode(account) | |
| .into(&mut arr) | |
| .expect("Failed to decode base58 string"); | |
| arr | |
| } |
There was a problem hiding this comment.
would be better to return a result
There was a problem hiding this comment.
Thanks, done 301544d.
We already have cleaner implementation for conversions like this btw, but there is a mess with photon_client & sdk types that needs to be untangled first.
I started doing it here, but its not finished yet #1515
ananas-block
approved these changes
Jan 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.