refactor: forester: queue fetching logic to support configurable indices #1200
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Enhanced fetch_queue_item_data to accept start index, length, and queue length parameters. Updated configuration to include queue settings and adjusted test cases accordingly.
| STATE_QUEUE_LENGTH=28807 | ||
| ADDRESS_QUEUE_START_INDEX=0 | ||
| ADDRESS_QUEUE_LENGTH=28807 |
There was a problem hiding this comment.
how easy is it to change these values?
Would it be easier to change if these are env variables?
ananas-block
approved these changes
Sep 11, 2024
There was a problem hiding this comment.
Looks good to me in general. The only thing I am worried about is that right now it seems like we will need to recompile the forester to change the parameters. I think it would be more elegant and flexible to use env variables that we read during runtime so that we can just restart the forester dynamically with a different config in case we want to run multiple foresters on short notice.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enhanced fetch_queue_item_data to accept start index, length, and queue length parameters.