Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: add verifiable build, reenable programs to be registered signer check #1182

Merged
merged 4 commits into from
Sep 9, 2024
Merged

chore: add verifiable build, reenable programs to be registered signer check #1182

merged 4 commits into from
Sep 9, 2024

Conversation

ananas-block
Copy link
Contributor

@ananas-block ananas-block commented Sep 9, 2024 •
edited
Loading

Changes:

  • add verifiable build
  • reenable program signer check for programs to be registered
  • remove commented check for protocol config init (it is already inited on mainnet and annoying in tests)

SwenSchaeferjohann
SwenSchaeferjohann reviewed Sep 9, 2024
View reviewed changes
programs/account-compression/src/instructions/register_program.rs
@@ -17,7 +17,7 @@ pub struct RegisterProgramToGroup<'info> {
#[account( mut, constraint= authority.key() == group_authority_pda.authority @AccountCompressionErrorCode::InvalidAuthority)]
pub authority: Signer<'info>,
/// CHECK: TODO: check that upgrade authority is signer.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove todo ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

want to keep this todo for a next release

SwenSchaeferjohann
SwenSchaeferjohann reviewed Sep 9, 2024
View reviewed changes
programs/registry/src/account_compression_cpi/register_program.rs
@@ -25,7 +25,7 @@ pub struct RegisterProgram<'info> {
pub registered_program_pda: AccountInfo<'info>,
/// CHECK: (account compression program). TODO: check that a signer is the upgrade authority.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove todo?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

want to keep this todo for a next release

@ananas-block ananas-block merged commit 1ca3e00 into main Sep 9, 2024
15 checks passed
@ananas-block ananas-block deleted the jorrit/chore-add-verifiable-build branch September 9, 2024 11:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SwenSchaeferjohann SwenSchaeferjohann SwenSchaeferjohann approved these changes

@vadorovsky vadorovsky Awaiting requested review from vadorovsky

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ananas-block @SwenSchaeferjohann