feat: add retry logic to RPC methods #1166
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added the 'async-trait' crate to provide async trait methods in RPC interfaces. Implemented async versions of existing synchronous methods and added retry logic for better error handling in 'SolanaRpcConnection'.
ananas-block
reviewed
Sep 8, 2024
| ..Default::default() | ||
| }, | ||
| ) | ||
| .map_err(RpcError::from) |
There was a problem hiding this comment.
we use this logic in send_transaction in forester which already has retry logic, is that retry logic now redundant?
There was a problem hiding this comment.
Yes. We need retry logic for each rpc method (otherwise we can easily throw out of from process_queue), so I decided to consolidate it in one place.
The `build_signed_transaction_batch` method in `TransactionBuilder` now uses `async_trait` to support async/await syntax. This change ensures better concurrency handling and simplifies the implementation of asynchronous code within the trait. Additionally, added a TODO comment about optimizing retry logic for sending transactions.
Move `async_trait::async_trait` to the correct location. This change improves code readability by maintaining a consistent import ordering.
ananas-block
approved these changes
Sep 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added the 'async-trait' crate to provide async trait methods in RPC interfaces.
Implemented async versions of existing synchronous methods and added retry logic for better error handling in 'SolanaRpcConnection'.