Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: change program ids and regenerate accounts #1104

Merged
merged 6 commits into from
Aug 22, 2024

Conversation

ananas-block
Copy link
Contributor

@ananas-block ananas-block commented Aug 19, 2024

Note:

  • signer checks checks for registering programs are commented because we don't want to hardcode our program id keypairs in this repo

@ananas-block ananas-block force-pushed the jorrit/chore-change-program-ids branch from 1588e70 to d3803e3 Compare August 19, 2024 20:19
@SwenSchaeferjohann SwenSchaeferjohann marked this pull request as ready for review August 20, 2024 01:32
@SwenSchaeferjohann SwenSchaeferjohann marked this pull request as draft August 20, 2024 01:32
@ananas-block ananas-block force-pushed the jorrit/chore-change-program-ids branch from 8736f1c to 1e10380 Compare August 21, 2024 17:56
@ananas-block ananas-block marked this pull request as ready for review August 21, 2024 17:57
@ananas-block ananas-block force-pushed the jorrit/chore-change-program-ids branch 3 times, most recently from 1645da9 to 5991ac8 Compare August 21, 2024 18:47
@ananas-block ananas-block force-pushed the jorrit/chore-change-program-ids branch from 5991ac8 to b8b88ad Compare August 21, 2024 19:13
ananas-block and others added 5 commits August 21, 2024 21:22
Updated `indexer_max_concurrent_batches` to 10 and `transaction_max_concurrent_batches` to 20 for better performance. Additionally, reduced iteration counts in two tests from 10 to 5 to expedite test completion.
run: |
source ./scripts/devenv.sh
npx nx test @lightprotocol/zk-compression-cli
#- name: Run CLI tests
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are they commented, because they are failing?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, all tests which include photon are disabled because photon has the old addresses hardcoded.

)
.unwrap();
}
// // init with invalid authority
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same here

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes it's commented because I commented the onchain check which makes this test fail see notes in description.

@sergeytimoshin sergeytimoshin merged commit 263fe5f into main Aug 22, 2024
15 checks passed
@sergeytimoshin sergeytimoshin deleted the jorrit/chore-change-program-ids branch August 22, 2024 18:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants