feat: forester: reduce get slot calls #1090
Conversation
forester/src/lib.rs
Outdated
| @@ -1,17 +1,24 @@ | |||
| pub type Result<T> = std::result::Result<T, ForesterError>; | |||
forester/src/slot_tracker.rs
Outdated
| last_known_slot: slot, | ||
| last_update_time: Instant::now(), | ||
| update_interval: Duration::from_secs(30), | ||
| slot_duration: Duration::from_millis(400), |
There was a problem hiding this comment.
would it make sense to make these values configurable?
There was a problem hiding this comment.
We should check whether slot time can drift or only block time drifts.
Additionally, we could check whether we can fetch average slot time from Solana rpc at startup if not its likely a hardcoded value and we should lookup the constant.
| }; | ||
|
|
||
| if current_slot >= target_slot { | ||
| let actual_slot = rpc.get_slot().await?; |
There was a problem hiding this comment.
The idea is wait until an expected slot with slot tracker and once reached double check with get slot?
We could also just call tracker.update() here.
There was a problem hiding this comment.
I refactored slot tracker a little bit, there is no waiting logic inside of tracker now, so I think it's outdated.
8330a1f to
80a20a6
Compare
There was a problem hiding this comment.
My comments are addressed, but there is still one from @ananas-block which is not #1090 (comment)
80a20a6 to
f13cd02
Compare
Add
SlotTrackerfor monitoring and synchronizing slots.