-
Notifications
You must be signed in to change notification settings - Fork 322
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Minor refactors - cleaning models #524
Minor refactors - cleaning models #524
Conversation
Codecov Report
@@ Coverage Diff @@
## master #524 +/- ##
==========================================
- Coverage 79.16% 77.53% -1.64%
==========================================
Files 114 114
Lines 6466 6664 +198
==========================================
+ Hits 5119 5167 +48
- Misses 1347 1497 +150
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
eef3f5c
to
3955170
Compare
3955170
to
2b6dc4d
Compare
e92d730
to
87a9722
Compare
from sklearn.datasets import load_boston | ||
except ModuleNotFoundError as err: | ||
raise ModuleNotFoundError( # pragma: no-cover | ||
else: # pragma: no cover |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
there an advantage or using "no cover" compare to "no-cover" I was thinking that the joined form is more like a tag :]
What does this PR do?
Closes #519 and closes #476.
Before submitting
PR review
Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.
Did you have fun?
Make sure you had fun coding 🙃