Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: update azure-pipelines schema #355

Merged
merged 5 commits into from
Jan 28, 2025
Merged

ci: update azure-pipelines schema #355

merged 5 commits into from
Jan 28, 2025

Conversation

Borda
Copy link
Member

@Borda Borda commented Jan 21, 2025

Before submitting
  • Was this discussed/agreed via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure to update the docs?
  • Did all existing and newly added tests pass locally?

What does this PR do?

need to be tested/validated on https://github.com/Lightning-AI/lightning-thunder/tree/main/.azure
trying to address

.azure/gpu-tests.yml
Error: schemafile was not valid

SchemaError: '^[^\\/~\\^\\: \\[\\]\\\\]+(\\/[^\\/~\\^\\: \\[\\]\\\\]+)*$' is not a 'regex'

Failed validating 'format' in metaschema['properties']['definitions']['additionalProperties']['properties']['pattern']:
    {'type': 'string', 'format': 'regex'}

On schema['definitions']['branchFilter']['pattern']:
    '^[^\\/~\\^\\: \\[\\]\\\\]+(\\/[^\\/~\\^\\: \\[\\]\\\\]+)*$'
  in "/opt/hostedtoolcache/Python/3.12.8/x64/lib/python3.12/site-packages/check_jsonschema/checker.py", line 56
  >>> return self._schema_loader.get_validator(

PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in GitHub issues there's a high chance it will not be merged.


📚 Documentation preview 📚: https://lit-utilities--355.org.readthedocs.build/en/355/

@github-actions github-actions bot added the ci/cd Continuous integration and delivery label Jan 21, 2025
requirements/gha-schema.txt Outdated Show resolved Hide resolved
@Borda Borda marked this pull request as ready for review January 28, 2025 09:41
@Borda Borda merged commit b10d1eb into main Jan 28, 2025
58 checks passed
@Borda Borda deleted the ci/schema branch January 28, 2025 09:41
@t-vi
Copy link

t-vi commented Jan 28, 2025

@Borda seems that it still causes problems check-schema fails for thunder.

Borda added a commit that referenced this pull request Jan 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci/cd Continuous integration and delivery dependencies
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants