Skip to content

Commit

Permalink
ci: rename import-extras to custom-import (#287)
Browse files Browse the repository at this point in the history
  • Loading branch information
Borda authored Jul 18, 2024
1 parent bc075c0 commit 4290889
Show file tree
Hide file tree
Showing 4 changed files with 12 additions and 6 deletions.
6 changes: 3 additions & 3 deletions .github/actions/pkg-install/action.yml
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ inputs:
description: "additional pip install flags"
required: false
default: "-f https://download.pytorch.org/whl/cpu/torch_stable.html"
import-extras:
custom-import:
description: "additional import statement, need to be full python code"
required: false
default: ""
Expand Down Expand Up @@ -53,7 +53,7 @@ runs:
run: |
set -ex
python -c "import ${{ inputs.import-name }} as pkg; print(f'version: {pkg.__version__}')"
python -c '${{ inputs.import-extras }}'
python -c '${{ inputs.custom-import }}'
shell: bash

- name: Uninstall all
Expand All @@ -76,5 +76,5 @@ runs:
run: |
set -ex
python -c "import ${{ inputs.import-name }} as pkg; print(f'version: {pkg.__version__}')"
python -c '${{ inputs.import-extras }}'
python -c '${{ inputs.custom-import }}'
shell: bash
4 changes: 2 additions & 2 deletions .github/workflows/check-package.yml
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ on:
description: "Import name to test with after installation"
required: true
type: string
import-extras:
custom-import:
description: "additional import statement, need to be full python code"
type: string
required: false
Expand Down Expand Up @@ -131,7 +131,7 @@ jobs:
pkg-extras: ${{ inputs.install-extras }}
pip-flags: ${{ inputs.install-flags }}
import-name: ${{ inputs.import-name }}
import-extras: ${{ inputs.import-extras }}
custom-import: ${{ inputs.custom-import }}

# TODO: add run doctests

Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/ci-use-checks.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,7 @@ jobs:
install-extras: "[cli]"
# todo: when we have a module with depence on extra, replace it
# tried to import `lightning_utilities.cli.__main__` but told me it does not exits
import-extras: "import fire"
custom-import: "import fire"
testing-matrix: |
{
"os": ["ubuntu-22.04", "macos-12", "windows-2022"],
Expand Down
6 changes: 6 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,12 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0

---

## [UnReleased] - 2024-MM-DD

### Changed

- CI: rename `import-extras` to `custom-import` in package check ([#287](https://github.com/Lightning-AI/utilities/pull/287))

## [0.11.4] - 2024-07-15

### Changed
Expand Down

0 comments on commit 4290889

Please sign in to comment.