Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Debug CI plot #1878

Merged
merged 2 commits into from
Jul 4, 2023
Merged

Debug CI plot #1878

merged 2 commits into from
Jul 4, 2023

Conversation

SkafteNicki
Copy link
Member

@SkafteNicki SkafteNicki commented Jul 4, 2023

What does this PR do?

Something happened to CI because windows has been failing since yesterday with segmentation faults during the plot testing.
https://github.com/Lightning-AI/torchmetrics/actions/runs/5447802124/jobs/9910639362
https://github.com/Lightning-AI/torchmetrics/actions/runs/5447246903/jobs/9909381752

Trying to debug here because cannot reproduce locally.

Before submitting
  • Was this discussed/agreed via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure to update the docs?
  • Did you write any new necessary tests?
PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃


📚 Documentation preview 📚: https://torchmetrics--1878.org.readthedocs.build/en/1878/

@SkafteNicki SkafteNicki added the test / CI testing or CI label Jul 4, 2023
@codecov
Copy link

codecov bot commented Jul 4, 2023

Codecov Report

Merging #1878 (07f6376) into master (13f85d0) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files
@@          Coverage Diff           @@
##           master   #1878   +/-   ##
======================================
  Coverage      85%     85%           
======================================
  Files         260     260           
  Lines       14908   14908           
======================================
  Hits        12657   12657           
  Misses       2251    2251           

@mergify mergify bot added the ready label Jul 4, 2023
@Borda Borda merged commit 8c5fab8 into master Jul 4, 2023
@Borda Borda deleted the debug_plot branch July 4, 2023 10:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready test / CI testing or CI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants