Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Weekly Patch Release v1.3.5 [full merge, no squash] #7881

Merged
merged 9 commits into from
Jun 9, 2021
Merged

Weekly Patch Release v1.3.5 [full merge, no squash] #7881

merged 9 commits into from
Jun 9, 2021

Conversation

SeanNaren
Copy link
Contributor

@SeanNaren SeanNaren commented Jun 8, 2021 •
edited by Borda
Loading

What does this PR do?

Fixes #<issue_number>

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

mauvilsa and others added 3 commits June 8, 2021 10:22
@mauvilsa
Fix support for torch Module type hints in LightningCLI (#7807)
c585913 
* Fixed support for torch Module type hints in LightningCLI

* - Fix issue with serializing values when type hint is Any.
- Run unit test only on newer torchvision versions in which the base class is Module.

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* Minor change

* Update CHANGELOG.md

Co-authored-by: Carlos Mocholí <carlossmocholi@gmail.com>

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Carlos Mocholí <carlossmocholi@gmail.com>

(cherry picked from commit f345840)
@shuyingsunshine21
[sharded plugin] Fix check for fp16 precision (#7825)
db77223 
Co-authored-by: Carlos Mocholí <carlossmocholi@gmail.com>
Co-authored-by: ananthsub <ananth.subramaniam@gmail.com>
(cherry picked from commit ca89a7f)
@justusschock
Add warning to trainstep output (#7779)
8c37c96 
* Update training_loop.py

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* Update test_training_loop.py

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* Update test_training_loop.py

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* Update training_loop.py

* Update pytorch_lightning/trainer/training_loop.py

Co-authored-by: Ethan Harris <ewah1g13@soton.ac.uk>

* Update test_training_loop.py

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* Update training_loop.py

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* Update pytorch_lightning/trainer/training_loop.py

Co-authored-by: ananthsub <ananth.subramaniam@gmail.com>

* Update training_loop.py

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* Update test_training_loop.py

* Update training_loop.py

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* escape regex

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Ethan Harris <ewah1g13@soton.ac.uk>
Co-authored-by: ananthsub <ananth.subramaniam@gmail.com>

(cherry picked from commit 6a0d503)
@SeanNaren SeanNaren added this to the v1.3.x milestone Jun 8, 2021
@pep8speaks
Copy link

pep8speaks commented Jun 8, 2021 •
edited
Loading

Hello @SeanNaren! Thanks for updating this PR.

Line 272:18: W503 line break before binary operator

Comment last updated at 2021-06-08 21:07:44 UTC

@SeanNaren SeanNaren self-assigned this Jun 8, 2021
@codecov
Copy link

codecov bot commented Jun 8, 2021 •
edited
Loading

Codecov Report

Merging #7881 (2872b01) into release/1.3.x (61525f6) will decrease coverage by 4%.
The diff coverage is 95%.

@@              Coverage Diff               @@
##           release/1.3.x   #7881    +/-   ##
==============================================
- Coverage             92%     87%    -4%     
==============================================
  Files                200     200            
  Lines              13016   13040    +24     
==============================================
- Hits               11958   11397   -561     
- Misses              1058    1643   +585

Borda and others added 4 commits June 8, 2021 10:30
@Borda
Fix NVIDIA docker versions (#7834)
2e1f675 
(cherry picked from commit 7b531ac)
@awaelchli
update fsspec to 2021.06.0 (#7869)
29ddc56 
(cherry picked from commit ce97676)
@tchaton
[bugfix] Resolve LearningRateMonitor + BackboneFinetuning (#7835)
0c12e88 
* add test + resolve bug

* update changelog

* resolve bug

* resolve bug

* Update pytorch_lightning/callbacks/lr_monitor.py

Co-authored-by: Jirka Borovec <Borda@users.noreply.github.com>

* Update pytorch_lightning/callbacks/lr_monitor.py

Co-authored-by: Jirka Borovec <Borda@users.noreply.github.com>

* update on comments

* resolve comments

* update

* Update tests/callbacks/test_lr_monitor.py

Co-authored-by: Carlos Mocholí <carlossmocholi@gmail.com>

* Update pytorch_lightning/callbacks/lr_monitor.py

Co-authored-by: Carlos Mocholí <carlossmocholi@gmail.com>

Co-authored-by: Jirka Borovec <Borda@users.noreply.github.com>
Co-authored-by: Carlos Mocholí <carlossmocholi@gmail.com>
(cherry picked from commit d1becce)
@kandluis
Move training_output validation to after train_step_end (#7868)
33bdf7b 
* move validation to after aggregation

* changelog

* add test for training_step_end

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>

(cherry picked from commit f9fccdf)
@SeanNaren SeanNaren marked this pull request as ready for review June 8, 2021 11:44
@Borda Borda added Important let's do it! approved to implement labels Jun 8, 2021
kaushikb11
kaushikb11 reviewed Jun 8, 2021
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
carmocca
carmocca reviewed Jun 8, 2021
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
Borda
Borda requested changes Jun 8, 2021
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
awaelchli
awaelchli approved these changes Jun 8, 2021
View reviewed changes
Copy link
Contributor

@awaelchli awaelchli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

apart from what was mentioned about changelog LGTM :))

@SeanNaren
Copy link
Contributor Author

Thanks for the keen eyes guys, should all be fixed :)

Borda
Borda requested changes Jun 8, 2021
View reviewed changes
Copy link
Member

@Borda Borda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am missing #7851 which is mentioned in the chlog

[bugfix] Minor improvements to apply_to_collection and type signatu…
2872b01 
…re of `log_dict` (#7851)

* minor fixeS

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
(cherry picked from commit 009e05d)
@lexierule lexierule merged commit c292788 into release/1.3.x Jun 9, 2021
@lexierule lexierule deleted the 1_3_5 branch June 9, 2021 00:32
@carmocca carmocca mentioned this pull request Jun 15, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kaushikb11 kaushikb11 kaushikb11 left review comments

@carmocca carmocca carmocca left review comments

@Borda Borda Borda requested changes

@ethanwharris ethanwharris ethanwharris approved these changes

@awaelchli awaelchli awaelchli approved these changes

@justusschock justusschock Awaiting requested review from justusschock

@tchaton tchaton Awaiting requested review from tchaton

@williamFalcon williamFalcon Awaiting requested review from williamFalcon

Assignees

@SeanNaren SeanNaren

Labels
let's do it! approved to implement
Projects
None yet
Milestone
pl:1.3.x
Development

Successfully merging this pull request may close these issues.