Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[IPU] Add special tests for IPUs 2/n #7833

Merged
merged 2 commits into from
Jun 4, 2021
Merged

[IPU] Add special tests for IPUs 2/n #7833

merged 2 commits into from
Jun 4, 2021

Conversation

SeanNaren
Copy link
Contributor

@SeanNaren SeanNaren commented Jun 4, 2021

What does this PR do?

Adds special tests for IPUs, and ensure we only run the profiler test if nvcc is available.

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

@SeanNaren SeanNaren added the ci Continuous Integration label Jun 4, 2021
@SeanNaren SeanNaren self-assigned this Jun 4, 2021
@SeanNaren SeanNaren added this to the v1.4 milestone Jun 4, 2021
@codecov
Copy link

codecov bot commented Jun 4, 2021

Codecov Report

Merging #7833 (b09c004) into master (ca89a7f) will decrease coverage by 5%.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master   #7833    +/-   ##
=======================================
- Coverage      93%     88%    -5%     
=======================================
  Files         199     202     +3     
  Lines       13017   13042    +25     
=======================================
- Hits        12052   11457   -595     
- Misses        965    1585   +620     

@awaelchli awaelchli added the ready PRs ready to be merged label Jun 4, 2021
@SeanNaren SeanNaren enabled auto-merge (squash) June 4, 2021 17:41
@SeanNaren SeanNaren merged commit 1083937 into master Jun 4, 2021
@SeanNaren SeanNaren deleted the feat/acc_2n branch June 4, 2021 17:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci Continuous Integration ready PRs ready to be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants