Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add warning to trainstep output #7779

Merged
merged 19 commits into from
Jun 4, 2021
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
[pre-commit.ci] auto fixes from pre-commit.com hooks
for more information, see https://pre-commit.ci
  • Loading branch information
pre-commit-ci[bot] committed Jun 2, 2021

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
commit 6f09c2b126d60d242679e28b7663d1cf4fa75423
5 changes: 2 additions & 3 deletions pytorch_lightning/trainer/training_loop.py
Original file line number Diff line number Diff line change
@@ -271,9 +271,8 @@ def _check_training_step_output(self, training_step_output):
raise MisconfigurationException("In manual optimization, `training_step` should not return a Tensor")
elif self.trainer.automatic_optimization:
if not (
isinstance(training_step_output, torch.Tensor) or (
isinstance(training_step_output, Mapping) and 'loss' in training_step_output
)
isinstance(training_step_output, torch.Tensor) or
(isinstance(training_step_output, Mapping) and 'loss' in training_step_output)
):
raise MisconfigurationException(
"In automatic optimization, `training_step` must either return a Tensor, "