Fix global step update when the epoch is skipped #7677
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #7677 +/- ##
======================================
- Coverage 93% 92% -0%
======================================
Files 200 200
Lines 12955 12965 +10
======================================
- Hits 11991 11964 -27
- Misses 964 1001 +37 |
awaelchli
approved these changes
May 24, 2021
carmocca
commented
May 24, 2021
| @@ -229,26 +229,6 @@ def train_dataloader(self): | |||
| trainer.fit(model) | |||
|
|
|||
|
|
|||
| @pytest.mark.parametrize('max_epochs,batch_idx_', [(2, 5), (3, 8), (4, 12)]) | |||
There was a problem hiding this comment.
Moved the test since it is testing more of the training loop internals than the model hook itself.
| model = CurrentModel() | ||
| trainer = Trainer(max_epochs=max_epochs, limit_train_batches=10) | ||
| trainer.fit(model) | ||
| if batch_idx_ > trainer.num_training_batches - 1: |
There was a problem hiding this comment.
This if was not running previously with the previous condition
ananthsub
approved these changes
May 24, 2021
tchaton
approved these changes
May 24, 2021
awaelchli
added a commit
that referenced
this pull request
May 25, 2021
awaelchli
added a commit
that referenced
this pull request
May 25, 2021
* Fix global step update when the epoch is skipped * Update CHANGELOG * Move test
Closed
Borda
pushed a commit
that referenced
this pull request
May 26, 2021
* Fix global step update when the epoch is skipped * Update CHANGELOG * Move test
11 tasks
lexierule
pushed a commit
that referenced
this pull request
May 26, 2021
* Fix global step update when the epoch is skipped * Update CHANGELOG * Move test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
When the epoch is skipped (
on_train_batch_startreturns-1),global_stepis still updated.This to me is wrong, even though we have tests for the previous behavior.
Added by @ydcjeff in #3700
Part of #7357
Before submitting
PR review