Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix progress bar print error when called before training #7674

Merged
merged 4 commits into from
May 24, 2021
Merged

Fix progress bar print error when called before training #7674

merged 4 commits into from
May 24, 2021

Conversation

ryanking13
Copy link
Contributor

@ryanking13 ryanking13 commented May 24, 2021

What does this PR do?

Fixes #7673

  • Check progress bar existence before printing
  • Use predict_progress_bar when printing at predict_step

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

@codecov
Copy link

codecov bot commented May 24, 2021

Codecov Report

Merging #7674 (75c7d93) into master (0c958c5) will decrease coverage by 5%.
The diff coverage is 100%.

@@           Coverage Diff           @@
##           master   #7674    +/-   ##
=======================================
- Coverage      93%     88%    -5%     
=======================================
  Files         200     200            
  Lines       12955   12964     +9     
=======================================
- Hits        11991   11381   -610     
- Misses        964    1583   +619     

Copy link
Member

@ethanwharris ethanwharris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, LGTM 😃

@Borda Borda added the bug Something isn't working label May 24, 2021
Copy link
Member

@Borda Borda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pls update changelog

@ryanking13
Copy link
Contributor Author

updated changelog

@ryanking13 ryanking13 changed the title Fix progress bar print error before training Fix progress bar print error when called before training May 24, 2021
@Borda Borda merged commit a54bc5d into Lightning-AI:master May 24, 2021
@carmocca carmocca added this to the v1.3.x milestone May 24, 2021
awaelchli added a commit that referenced this pull request May 25, 2021
* Check progress bar existence before printing

* Add tests for predict_progres_bar

* Add tests for progress_bar printing without training

* Update changelog
update changelog
@Borda Borda mentioned this pull request May 25, 2021
Borda pushed a commit that referenced this pull request May 26, 2021
* Check progress bar existence before printing

* Add tests for predict_progres_bar

* Add tests for progress_bar printing without training

* Update changelog
update changelog
lexierule pushed a commit that referenced this pull request May 26, 2021
* Check progress bar existence before printing

* Add tests for predict_progres_bar

* Add tests for progress_bar printing without training

* Update changelog
update changelog
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

LightningModule.print() fails when it is called before training
5 participants