Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sharded DDP Docs #4920

Merged
merged 24 commits into from
Dec 2, 2020
Merged

Sharded DDP Docs #4920

merged 24 commits into from
Dec 2, 2020

Conversation

SeanNaren
Copy link
Contributor

@SeanNaren SeanNaren commented Nov 30, 2020 •
edited by Borda
Loading

What does this PR do?

Fixes # (issue)

Before submitting

  • Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together? Otherwise, we ask you to create a separate PR for every change.
  • Did you make sure to update the documentation with your changes?
  • Did you write any new necessary tests?
  • Did you verify new and existing tests pass locally with your changes?
  • If you made a notable change (that affects users), did you update the CHANGELOG?

PR review

Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified; Bugfixes should be including in bug-fix release milestones (m.f.X) and features should be included in (m.X.b) releases.

Did you have fun?

Make sure you had fun coding 🙃

@SeanNaren SeanNaren added the docs Documentation related label Nov 30, 2020
@SeanNaren SeanNaren changed the title [CI SKIP] Backend Docs [CI SKIP] Sharded DDP Nov 30, 2020
@SeanNaren SeanNaren changed the title [CI SKIP] Sharded DDP [CI SKIP] Sharded DDP Docs Nov 30, 2020
@codecov
Copy link

codecov bot commented Nov 30, 2020 •
edited
Loading

Codecov Report

Merging #4920 (4bcd91b) into master (add387c) will increase coverage by 0%.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master   #4920    +/-   ##
=======================================
  Coverage      93%     93%            
=======================================
  Files         124     124            
  Lines        9203    9320   +117     
=======================================
+ Hits         8524    8640   +116     
- Misses        679     680     +1

@edenlightning edenlightning added this to the 1.1 milestone Dec 1, 2020
SeanNaren and others added 3 commits December 1, 2020 20:43
@SeanNaren @edenlightning
Update docs/source/multi_gpu.rst
885eb51 
Co-authored-by: edenlightning <66261195+edenlightning@users.noreply.github.com>
Address code review points
9844c69
Added caveat, increase performance
e022cdb
SeanNaren and others added 2 commits December 1, 2020 22:16
@SeanNaren @edenlightning
Update docs/source/multi_gpu.rst
8eb3afa 
Co-authored-by: edenlightning <66261195+edenlightning@users.noreply.github.com>
@SeanNaren @edenlightning
Update docs/source/multi_gpu.rst
5895a59 
Co-authored-by: edenlightning <66261195+edenlightning@users.noreply.github.com>
Borda
Borda reviewed Dec 1, 2020
View reviewed changes
docs/source/performance.rst Outdated Show resolved Hide resolved
Borda
Borda approved these changes Dec 2, 2020
View reviewed changes
Copy link
Member

@Borda Borda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

tchaton
tchaton reviewed Dec 2, 2020
View reviewed changes
docs/source/multi_gpu.rst Outdated Show resolved Hide resolved
@Borda Borda added the ready PRs ready to be merged label Dec 2, 2020
@SeanNaren SeanNaren changed the title [CI SKIP] Sharded DDP Docs Sharded DDP Docs Dec 2, 2020
SeanNaren and others added 2 commits December 2, 2020 10:20
@SeanNaren SeanNaren merged commit 0c763b2 into master Dec 2, 2020
@SeanNaren SeanNaren deleted the feature/docsddp branch December 2, 2020 11:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tchaton tchaton tchaton left review comments

@edenlightning edenlightning edenlightning approved these changes

@justusschock justusschock justusschock approved these changes

@teddykoker teddykoker teddykoker approved these changes

@ananyahjha93 ananyahjha93 ananyahjha93 approved these changes

@Borda Borda Borda approved these changes

@awaelchli awaelchli Awaiting requested review from awaelchli

@nateraw nateraw Awaiting requested review from nateraw

@williamFalcon williamFalcon Awaiting requested review from williamFalcon

Assignees
No one assigned
Labels
docs Documentation related ready PRs ready to be merged
Projects
None yet
Milestone
pl:1.1
Development

Successfully merging this pull request may close these issues.
7 participants
@SeanNaren @Borda @ananyahjha93 @teddykoker @tchaton @justusschock @edenlightning