Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix setup-doc for pypi #472

Merged
merged 9 commits into from
Nov 9, 2019
Merged

Fix setup-doc for pypi #472

merged 9 commits into from
Nov 9, 2019

Conversation

Borda
Copy link
Member

@Borda Borda commented Nov 7, 2019

Before submitting

  • Was this discussed/approved via a Github issue? (no need for typos, doc improvements)
  • Did you read the contributor guideline?
  • Did you make sure to update the docs?
  • Did you write any new necessary tests?

What does this PR do?

Fixes #468.

PR review

  • Anyone in the community is free to review the PR once the tests have passed.
  • If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

@williamFalcon
Copy link
Contributor

@Borda the build is currently broken because of pip install -rrequirements.txt (ie: spacing issue). Where is that happening? can you fix in this PR as well?

@Borda
Copy link
Member Author

Borda commented Nov 9, 2019

@williamFalcon can you link the failing build, because checks for this PR seems to be fine...

@williamFalcon
Copy link
Contributor

it's on master

@Borda
Copy link
Member Author

Borda commented Nov 9, 2019

@williamFalcon yes, you had multiple declarations of test-tube... fixed in 3457841
the break was when you added test-tube to requirements.txt without waiting for CI to pass :]

@williamFalcon williamFalcon merged commit 1fd1e42 into Lightning-AI:master Nov 9, 2019
@Borda Borda deleted the issue_468 branch November 9, 2019 06:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix readme for Pypi
2 participants