ref: part 8 of #3733 #3806
Merged
ref: part 8 of #3733 #3806
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #3806 +/- ##
=======================================
+ Coverage 88% 89% +2%
=======================================
Files 110 110
Lines 8873 8677 -196
=======================================
- Hits 7770 7737 -33
+ Misses 1103 940 -163 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continuing DDP refactors.
Isolates DDP class.
Next steps, split the following sub-backends:
ddp slurm
ddp script
ddp torchelastic
fix the DDP bugs
then create cluster managers abstraction (slurm, torchelastic) as inputs to ddp.
Right now i just don't want to break things, so, refactors are slow but rigorous.