Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #2407 #2981

Merged
merged 7 commits into from
Aug 14, 2020
Merged

Fixes #2407 #2981

merged 7 commits into from
Aug 14, 2020

Conversation

williamFalcon
Copy link
Contributor

Removes --gpus flag from ddp call. should also help hydra users @omry

@mergify mergify bot requested a review from a team August 14, 2020 20:00
@williamFalcon
Copy link
Contributor Author

Fixed @cinjon

@codecov
Copy link

codecov bot commented Aug 14, 2020

Codecov Report

Merging #2981 into master will increase coverage by 5%.
The diff coverage is 17%.

@@           Coverage Diff           @@
##           master   #2981    +/-   ##
=======================================
+ Coverage      85%     90%    +5%     
=======================================
  Files          82      81     -1     
  Lines        7719    7556   -163     
=======================================
+ Hits         6550    6799   +249     
+ Misses       1169     757   -412     

@williamFalcon williamFalcon merged commit e7794eb into master Aug 14, 2020
@Borda Borda deleted the ddpb branch August 14, 2020 20:23
@Borda Borda added the bug Something isn't working label Aug 14, 2020
@mergify mergify bot requested a review from a team August 14, 2020 20:26
@omry
Copy link
Contributor

omry commented Aug 14, 2020

Nice, thanks.

@cinjon
Copy link
Contributor

cinjon commented Aug 16, 2020

Thanks! Seems to work well 👍

ameliatqy pushed a commit to ameliatqy/pytorch-lightning that referenced this pull request Aug 17, 2020
@Borda Borda added this to the 0.9.0 milestone Aug 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants