Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

skip best_model_path if checkpoint_callback is None #2962

Merged
merged 2 commits into from
Oct 1, 2020
Merged

skip best_model_path if checkpoint_callback is None #2962

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2381c3d
skip best_model_path if checkpoint_callback is None
lezwon Aug 13, 2020
51f495b
removed test
lezwon Oct 1, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion pytorch_lightning/accelerators/tpu_backend.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,8 @@ def teardown(self):
last_path = self.mp_queue.get()

# transfer back the best path to the trainer
self.trainer.checkpoint_callback.best_model_path = best_path
if self.trainer.checkpoint_callback is not None:
self.trainer.checkpoint_callback.best_model_path = best_path
Comment on lines +70 to +71
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

how about we just merge this one line fix into master? This would close the issue before release and you can still figure out the hard testing part for TPU in the other PR that's blocking this.
cc @Borda

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sounds good to me...

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's sounds good 👍

# todo, pass also bets score

# load last weights
Expand Down