Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix typo #1118

Merged
merged 1 commit into from
Mar 12, 2020
Merged

Fix typo #1118

merged 1 commit into from
Mar 12, 2020

Conversation

christabella
Copy link
Contributor

@christabella christabella commented Mar 11, 2020 •
edited by Borda
Loading

Before submitting

  • Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure to update the docs?
  • Did you write any new necessary tests?
  • If you made a notable change (that affects users), did you update the CHANGELOG?

What does this PR do?

Fixes a typo "engineerng"

PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

@ethanwharris ethanwharris added ready PRs ready to be merged docs Documentation related labels Mar 11, 2020
@Borda
Copy link
Member

Borda commented Mar 11, 2020

hey there, we have added GPU CI test, so could we kindly ask to rebase/merge master which will trigger these tests so we do not need to test it manually... Thx for your understanding 🤖

@christabella christabella force-pushed the christabella-fix-typo branch from 65fe680 to 7c89338 Compare March 12, 2020 07:53
@williamFalcon williamFalcon merged commit fb27a77 into Lightning-AI:master Mar 12, 2020
tullie pushed a commit to tullie/pytorch-lightning that referenced this pull request Apr 3, 2020
@christabella @tullie
Fix typo (Lightning-AI#1118)
81b24cc
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ethanwharris ethanwharris ethanwharris approved these changes

Assignees
No one assigned
Labels
docs Documentation related ready PRs ready to be merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@christabella @Borda @ethanwharris @williamFalcon