Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

prune codecov exceptions #1107

Merged
merged 1 commit into from
Mar 16, 2020
Merged

prune codecov exceptions #1107

merged 1 commit into from
Mar 16, 2020

Conversation

Borda
Copy link
Member

@Borda Borda commented Mar 9, 2020

What does this PR do?

Most of the patterns does not exist anymore in code, so if need add local # pragma: no cover

PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

@Borda Borda added the feature Is an improvement or enhancement label Mar 9, 2020
@Borda Borda requested a review from a team March 9, 2020 23:46
@Borda Borda force-pushed the reduce-cov-omits branch from 50e954d to ea71291 Compare March 11, 2020 20:45
@Borda Borda added this to the 0.7.2 milestone Mar 12, 2020
@Borda
Copy link
Member Author

Borda commented Mar 13, 2020

@PyTorchLightning/core-contributors ^^

@Borda Borda added bug Something isn't working ci Continuous Integration labels Mar 13, 2020
@Borda Borda requested a review from luiscape March 16, 2020 18:37
@williamFalcon williamFalcon merged commit c89e482 into master Mar 16, 2020
@Borda Borda deleted the reduce-cov-omits branch March 16, 2020 19:16
tullie pushed a commit to tullie/pytorch-lightning that referenced this pull request Apr 3, 2020
@Borda Borda modified the milestones: v0.7., v0.7.x Apr 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working ci Continuous Integration feature Is an improvement or enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants