Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cleaning imports #1032

Merged
merged 1 commit into from
Mar 12, 2020
Merged

cleaning imports #1032

merged 1 commit into from
Mar 12, 2020

Conversation

Borda
Copy link
Member

@Borda Borda commented Mar 3, 2020

What does this PR do?

nothing special, just cleaning unused imports except these needed for back-compatibility

PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

@Borda Borda added the feature Is an improvement or enhancement label Mar 3, 2020
@Borda Borda requested a review from ethanwharris March 3, 2020 18:27
Copy link
Member

@ethanwharris ethanwharris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Borda Borda added this to the 0.7.2 milestone Mar 7, 2020
@Borda Borda requested a review from luiscape March 11, 2020 23:33
@Borda Borda added the ready PRs ready to be merged label Mar 12, 2020
@williamFalcon williamFalcon merged commit 514d182 into Lightning-AI:master Mar 12, 2020
@Borda Borda deleted the imports branch March 12, 2020 17:11
tullie pushed a commit to tullie/pytorch-lightning that referenced this pull request Apr 3, 2020
@Borda Borda modified the milestones: v0.7., v0.7.x Apr 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature Is an improvement or enhancement ready PRs ready to be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants