-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Gemma checkpoint support #941
Conversation
|
Btw @carmocca or @Andrei-Aksionov please feel free to continue this PR if you have time and are interested. I may have to put in a stop for now due to another project that is due soon ... I thought it was more of a simpler port and thought that's something I could do in ~1 h but it appears I got a bit stuck here and have to put in a break for now. |
I cannot make changes to others PRs, so I guess Carlos is the only one :).
So many of us have been in this situation before ... |
Thanks for the updates so far and getting the 2B to work! |
@rasbt Do we really need all of these steps?
I did a sanity check with LoRA fine-tuning and had no errors. And there couldn't be any errors, since we didn't change anything related to training. Plus we have tests that check if LoRA and Adapter are appliable to the model. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Excellent job!
Co-authored-by: Carlos Mocholí <carlossmocholi@gmail.com>
Co-authored-by: Carlos Mocholí <carlossmocholi@gmail.com>
Co-authored-by: Carlos Mocholí <carlossmocholi@gmail.com>
Co-authored-by: Carlos Mocholí <carlossmocholi@gmail.com> Co-authored-by: Andrei-Aksionov <aksionau.andrei@gmail.com>
Adds the new Gemma models by Google.
generate.py
produces reasonable outputs-it
(aka instruct) versionsFixes #940