Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Relative paths and model configuration #28

Merged
merged 26 commits into from
Mar 27, 2023
Merged

Relative paths and model configuration #28

merged 26 commits into from
Mar 27, 2023

Conversation

awaelchli
Copy link
Contributor

@awaelchli awaelchli commented Mar 27, 2023

Fixes #24
Fixes #23

  • Makes paths relative. After this PR lands, you can link the existing checkpoints on our server like so: ln -s /srv/data/checkpoints checkpoints
  • Adds the other model configurations for 13B, 30B, and 65B accessible by name.

@awaelchli awaelchli marked this pull request as ready for review March 27, 2023 15:32
@awaelchli awaelchli requested a review from carmocca March 27, 2023 16:12
Copy link
Collaborator

@lantiga lantiga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved but I would also remove original_model from generate.py

@awaelchli awaelchli merged commit 17d7f7e into main Mar 27, 2023
@awaelchli awaelchli deleted the hardcoded-paths branch March 27, 2023 16:59
gkroiz pushed a commit to gkroiz/lit-llama that referenced this pull request May 9, 2023
timothylimyl referenced this pull request in timothylimyl/lit-llama-qa May 21, 2023
Co-authored-by: Luca Antiga <luca@lightning.ai>
Co-authored-by: Carlos Mocholí <carlossmocholi@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make loading paths configurable Add support for pre-configured sizes
3 participants