Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/encounter dispositions #30

Merged
merged 6 commits into from
Aug 9, 2022
Merged

Conversation

edcohen08
Copy link
Contributor

This pull request adds getting and updating encounter dispositions. It adds the Disposition resource and a utility model EncounterSubResource for Encounter subresources to get the patient id and encounter id.

As a note fixes a QOL bug in the test_authentication that caused problems running new tests as part of the entire test suite because of overwriting the auth token.

@edcohen08 edcohen08 requested a review from samamorgan August 9, 2022 17:28
@codecov
Copy link

codecov bot commented Aug 9, 2022

Codecov Report

Merging #30 (f1a2bd3) into develop (4a7c768) will increase coverage by 0.08%.
The diff coverage is 92.59%.

@@             Coverage Diff             @@
##           develop      #30      +/-   ##
===========================================
+ Coverage    93.14%   93.22%   +0.08%     
===========================================
  Files           23       24       +1     
  Lines         1108     1166      +58     
===========================================
+ Hits          1032     1087      +55     
- Misses          76       79       +3     
Impacted Files Coverage Δ
test/test_authentication.py 96.77% <50.00%> (-3.23%) ⬇️
welkin/models/util.py 79.16% <79.16%> (ø)
test/test_encounters.py 98.83% <100.00%> (+0.26%) ⬆️
welkin/models/__init__.py 100.00% <100.00%> (ø)
welkin/models/assessment.py 92.85% <100.00%> (+2.61%) ⬆️
welkin/models/encounter.py 94.73% <100.00%> (+1.40%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Collaborator

@samamorgan samamorgan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@edcohen08 edcohen08 merged commit ed8d9e3 into develop Aug 9, 2022
@edcohen08 edcohen08 deleted the feature/encounter-dispositions branch August 9, 2022 18:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants