Core (LV::AudioConvert): Rewrite audio sample conversion #381
+127
−149
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ne of numerical errors.
0bb0776 to
bb626f3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Did extensive testing of the audio sample conversion and found a tonne of egregious numerical errors.
This PR fixes all of the known bugs. Where the conversion accuracy is sacrificed for performance, I have quantified the errors (with proofs!).
I don't know if they were introduced when I ported the original C macros to C++ generics, or during its refinements over time with modern C++-isms. If the bugs are present in the C original, I can backport the fixes over to 0.4.x.
More (gory) details to follow.