Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Core (Build): Get ORC compiler executable path from pkg-config. #378

Merged
merged 1 commit into from
Jan 16, 2025
Merged

Core (Build): Get ORC compiler executable path from pkg-config. #378

merged 1 commit into from
Jan 16, 2025

Conversation

kaixiong
Copy link
Member

ORC's pkg-config file conveniently contains the path to the ORC compiler (orcc), so we should use that instead of searching for the executable in PATH.

@kaixiong kaixiong requested a review from hartwork January 15, 2025 19:48
@kaixiong kaixiong self-assigned this Jan 15, 2025
hartwork
hartwork approved these changes Jan 16, 2025
View reviewed changes
Copy link
Member

@hartwork hartwork left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kaixiong there is no use of ORC in 0.4.x code that I could find, is that correct? If so, I would create a pull request dropping installation of ORC from 0.4.x CI.

@kaixiong kaixiong merged commit 9c932a6 into master Jan 16, 2025
6 checks passed
@kaixiong kaixiong deleted the fix-orcc-search branch January 16, 2025 05:50
@kaixiong
Copy link
Member Author

@hartwork yes, ORC was introduced in master.

@hartwork hartwork mentioned this pull request Jan 16, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hartwork hartwork hartwork approved these changes

Assignees

@kaixiong kaixiong

Labels
enhancement porting: not needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kaixiong @hartwork