#147 Go back to the folder where you opened the book after you closed it #159
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When exiting ReadingPage, the home page will now retain the selected folder, and also open the folder sidebar, as in the issue Librum-Reader#147
|
This seems to always open the folder sidebar, even when it was closed before. |
|
I think it would make more sense to have a variable in main.qml "folderSidebarOpened" that we set when the homepage is destroyed and read when the home page is loaded |
|
Oh, actually it is as easy as not resetting the folder we sort by when leaving the home page, I'll make a commit for that and close this |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When exiting ReadingPage, the home page will now retain the selected folder, and also open the folder sidebar, as in the issue #147