Cleanups after PR #1082 #1088
Merged
Cleanups after PR #1082 #1088
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
asturio
commented
Mar 2, 2024
- fillerCmap is private Map and has getter and "putter"
- simplified getSentenceMissingCmap
- use more modern Java features
- lesser cleanups
- fillerCmap is private Map and has getter and "putter" - simplified getSentenceMissingCmap - use more modern Java features - lesser cleanups
Coverage summary from CodacySee diff coverage on Codacy
Coverage variation details
Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: Diff coverage details
Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: See your quality gate settings Change summary preferencesYou may notice some variations in coverage metrics with the latest Coverage engine update. For more details, visit the documentation |
- Remove unused Method convertToBytes - Add more Tests - Added Font Awesome to tests
- force using getter for fillerCmap - more Tests for FontDetails - renamed (test) fonts/liberation-serif to fonts/liberation - added a smoke Test for creating a simple document
- rename check-Method in assert - Codacy issues fixed
311095a to
ef11e5a
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.