Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide PDF/A conform annotations #1084

Merged
merged 1 commit into from
Feb 29, 2024

Conversation

vuilleumierc
Copy link
Contributor

Description of the new Feature/Bugfix

It's currently not possible to create annotations which are PDF/A conform. The validation test with VeraPDF fails with this message:

ruleId=RuleId [specification=ISO 19005-1:2005, clause=6.5.3, testNumber=2], status=failed, message=An annotation dictionary shall contain the F key. The F key’s Print flag bit shall be set to 1 and its Hidden, Invisible and NoView flag bits shall be set to 0

Related Issue: #980

Unit-Tests for the new Feature/Bugfix

  • Unit-Tests added to reproduce the bug
  • Unit-Tests added to the added feature

Compatibilities Issues

As far as I can tell this does not cause compatibility issues.
Would you consider a backport to 1.3.x?

Testing details

Not that I know of.

Thanks in advance for your review / comments

Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@vuilleumierc
Copy link
Contributor Author

Any advice on the CodeFactor issue?
I already refactored the changes into one method. I don't see how to further reduce the complexity apart from refactoring the existing constructors, which seems to be beyond the scope of this PR

@asturio asturio linked an issue Feb 29, 2024 that may be closed by this pull request
@asturio asturio self-assigned this Feb 29, 2024
@asturio
Copy link
Member

asturio commented Feb 29, 2024

I think the tools are a little too paranoid by now. Still configuring then. CodeFactor is ok.

Further PRs for 1.4 and 1.3 are welcome. Backport should not be a problem.

@asturio asturio merged commit cdbdc7c into LibrePDF:master Feb 29, 2024
6 of 8 checks passed
@andreasrosdal
Copy link
Contributor

Will you submit PRs for the other PDF/A issues described in #980? Thank you!

@vuilleumierc
Copy link
Contributor Author

I think the only blocking issue for us was with the annotations (see Jaspersoft/jasperreports#410)
For instance calling createXmpMetadata() already solves a couple of these errors.
But we will keep that in mind and we much appreciate the possibility to submit PRs 👍

@vuilleumierc vuilleumierc deleted the pdf-a-annotation branch May 3, 2024 07:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

PDF/A support
3 participants