You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Is there a way how to squash all commits into one before merging it? This is possible with GitLab, but I don't know if GitHub can do. Reason: more often then not, one commit is not enough, e.g. you get a warning from static code analysis, or you need to change something based on somebody else's comment. But these additional commits then only make the history too long.
Is there a way how to squash all commits into one before merging it? This is possible with GitLab, but I don't know if GitHub can do. Reason: more often then not, one commit is not enough, e.g. you get a warning from static code analysis, or you need to change something based on somebody else's comment. But these additional commits then only make the history too long.
I think the mantainers can squash the commits when merging the PR.
Otherwise, you can squash the commits on your local copy (git rebase -i HEAD~2) ant then force push.
* #1057 Generating PDF from HTML containing CSS font-size property fails with IllegalArgumentException
---------
Co-authored-by: Radek Wikturna <radek.wikturna@usu.com>
* #1057 Generating PDF from HTML containing CSS font-size property fails with IllegalArgumentException
---------
Co-authored-by: Radek Wikturna <radek.wikturna@usu.com>
@asturio, thanks a lot for merging it. Are you going to merge it also to 1.4 and main branch?
RadekWikturna
deleted the
#1057_Generating_PDF_from_HTML_containing_CSS_font-size_property_fails_with_IllegalArgumentException
branch
February 23, 2024 08:48
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the new Feature/Bugfix
Added support for font size specified by name, e.g. 'small' or 'large'
Related Issue: #1057
Unit-Tests for the new Feature/Bugfix
Compatibilities Issues
None
Testing details
Run the
FontSizeTest.testNamedFontSize. See also the generated 'Font Size Named.pdf'