Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

init: ondemand tuning #3538

Closed
wants to merge 2 commits into from
Closed

init: ondemand tuning #3538

wants to merge 2 commits into from

Conversation

kszaq
Copy link
Contributor

@kszaq kszaq commented May 29, 2019

Set all ondemand tunables like it's done for RPi. Thanks to these GUI animations feel smoother, particularly on ARM targets.

Copy link
Member

@lrusak lrusak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm fine with that. Thanks!

@MilhouseVH
Copy link
Contributor

On RPi/RPi2 with this PR I'm getting this:

s1

and then the system is dead. Will dig into this tomorrow (Fri) unless anyone has any bright ideas!

@HiassofT
Copy link
Member

As also commented in slack I'd prefer cpufreq tweaks to be a standard systemd unit - this allows easier tweaking (or disabling) if needed

@MilhouseVH
Copy link
Contributor

The RPi/RPi2 failures may be the result of an interaction between this PR and #3537 (package bumps) which I'm also including in my builds. A build with both #3537 and this PR results in the previously mentioned boot problems, but with only this PR (and without #3537) is booting OK. Hmmm.

Will try and narrow it down Friday - currently clean building RPi2 on a second machine with both this PR and #3537 to see if I can reproduce the original boot problem.

@MilhouseVH
Copy link
Contributor

I haven't been able to reproduce the previously reported boot issue so far, maybe it was a one-off (or ccache related?) issue and thus a red herring. A new build with both #3538 and #3537 is booting normally while a similar build would not boot last night. Very odd.

As mentioned on Slack it would be better to tweak platforms on a project/device basis (maybe using systemd, or platform_init), and something like the default governor could also be set in the kernel config. Setting the same cpufreq settings for all devices may become a problem in future if we need to use different settings for a specific project and/or device.

@MilhouseVH
Copy link
Contributor

Also... this PR doesn't actually work - add debugging break=all to single step init:

s1

😄

@kszaq
Copy link
Contributor Author

kszaq commented May 31, 2019

@MilhouseVH Thank you for extensive testing! I'll leave this PR open and amend according to suggestions when I find some time...

kszaq added 2 commits June 5, 2019 23:09
Set all ondemand tunables like it's done for RPi.
Thanks to these GUI animations feel smoother,
particularly on ARM targets.
@kszaq kszaq force-pushed the ondemand_tuning branch from 0f83c45 to 4a41048 Compare June 5, 2019 21:09
@kszaq
Copy link
Contributor Author

kszaq commented Jun 5, 2019

Changed modifications in init to not use find.

@MilhouseVH
Copy link
Contributor

Close now, after #3896?

@chewitt
Copy link
Member

chewitt commented Nov 17, 2019

Closing as the PR wa superseeded with #3896

@chewitt chewitt closed this Nov 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants