Added support for stacktrace vars #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Do you have any idea how this affects performance? This can already be quite a slow process and I wouldn't want to nuke a server with an error in a think hook. (Though really, implementing sampling would probably fix that regardless) |
|
Unfortunately I haven't tested the performance of this, I can do it in a few days. Maybe lag during spam could be combated by early on quitting for repeated errors in some clever way. |
Sends locals and upvalues to Sentry for each stack level
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This sends all locals (including function parameters) and optionally upvalues to Sentry aswell for every stack level, which facilitates easier debugging. Both locals and upvalues can be disabled via the config options.
Upvalues are disabled by default because they can become quite many.