This repository has been archived by the owner on Dec 2, 2024. It is now read-only.
add tests from abstract-leveldown #1
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
ok, this is kindof pointless now, since all the tests already pass but the forced downgrade of abstract-leveldown breaks other tests. or what do you think? |
|
why is the downgrade necessary? |
|
because the tests that ship with current abstract-leveldown aren't compatibly with the version of levelup we're using |
|
i'm still not sure if this test suite is even useful, i tried to break some tests by changing lines to not make sense, but they still passed |
|
whoa haha. that doesn't sound comforting |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
some are failing, some are passing :)
consider this a WIP pull request