Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Breaking: upgrade to abstract-level 3 #112

Merged
merged 1 commit into from
Jan 26, 2025
Merged

Conversation

vweevers
Copy link
Member

No description provided.

@vweevers vweevers added the semver-major Changes that break backward compatibility label Jan 26, 2025
@vweevers
Copy link
Member Author

Blegh, fails on some unrelated electron thing:

Command: npm run test-electron
/usr/bin/xvfb-run --auto-servernum npm run test-electron

> classic-level@2.0.0 test-electron
> electron test/electron.js

[3550:0[12](https://github.com/Level/classic-level/actions/runs/12976869518/job/36189627026?
pr=112#step:8:13)6/173356.437754:FATAL:setuid_sandbox_host.cc(158)] The SUID sandbox helper binary was
found, but is not configured correctly. Rather than run without sandboxing I'm aborting now. You need to
make sure that /home/runner/work/classic-level/classic-level/node_modules/electron/dist/chrome-sandbox
is owned by root and has mode 4755.
/home/runner/work/classic-level/classic-level/node_modules/electron/dist/electron exited with signal
SIGTRAP
/usr/bin/bash /home/runner/work/_actions/GabrielBB/xvfb-action/v1/cleanup.sh
No xvfb processes to kill
Error: The process '/usr/bin/xvfb-run' failed with exit code 1

@vweevers
Copy link
Member Author

The solution is to lift the restrictions that Ubuntu 24.04 implements in the AppImages.

sudo sysctl -w kernel.apparmor_restrict_unprivileged_userns=0

electron/electron#42510 (comment)

It seems ill-advised and a bit silly to disable an OS security feature in order to enable an Electron security feature (sandboxing) but should be okay to do this in our GHA workflows. At least until Electron has an official solution.

vweevers added a commit that referenced this pull request Jan 26, 2025
vweevers added a commit that referenced this pull request Jan 26, 2025
Ref: #112 (comment)
Category: none
@vweevers vweevers mentioned this pull request Jan 26, 2025
vweevers added a commit that referenced this pull request Jan 26, 2025
@vweevers vweevers force-pushed the bump-abstract-level-3 branch from b9302aa to e4ff2b4 Compare January 26, 2025 18:09
@vweevers vweevers merged commit 812fe88 into main Jan 26, 2025
26 checks passed
@vweevers vweevers deleted the bump-abstract-level-3 branch January 26, 2025 18:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
semver-major Changes that break backward compatibility
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

1 participant