make testCommon.js the default value for testCommon parameter + remove testBuffer

abstract/batch-test.js

@@ -267,6 +267,7 @@ module.exports.tearDown = function (test, testCommon) {
 }
 
 module.exports.all = function (leveldown, test, testCommon) {
+  testCommon = testCommon || require('../testCommon')
   module.exports.setUp(leveldown, test, testCommon)
   module.exports.args(test)
   module.exports.batch(test)

abstract/chained-batch-test.js

@@ -255,6 +255,7 @@ module.exports.tearDown = function (test, testCommon) {
 }
 
 module.exports.all = function (leveldown, test, testCommon) {
+  testCommon = testCommon || require('../testCommon')
   module.exports.setUp(leveldown, test, testCommon)
   module.exports.args(test)
   module.exports.batch(test, testCommon)

abstract/close-test.js

@@ -1,4 +1,5 @@
 module.exports.close = function (leveldown, test, testCommon) {
+  testCommon = testCommon || require('../testCommon')
   test('test close()', function (t) {
     var db = leveldown(testCommon.location())
 

abstract/del-test.js

@@ -89,6 +89,7 @@ module.exports.tearDown = function (test, testCommon) {
 }
 
 module.exports.all = function (leveldown, test, testCommon) {
+  testCommon = testCommon || require('../testCommon')
   module.exports.setUp(leveldown, test, testCommon)
   module.exports.args(test)
   module.exports.del(test)

abstract/get-test.js

@@ -166,6 +166,7 @@ module.exports.tearDown = function (test, testCommon) {
 }
 
 module.exports.all = function (leveldown, test, testCommon) {
+  testCommon = testCommon || require('../testCommon')
   module.exports.setUp(leveldown, test, testCommon)
   module.exports.args(test)
   module.exports.get(test)

abstract/iterator-range-test.js

@@ -355,6 +355,8 @@ module.exports.tearDown = function (test, testCommon) {
 }
 
 module.exports.all = function (leveldown, test, testCommon) {
+  testCommon = testCommon || require('../testCommon')
+
   var data = (function () {
     var d = []
     var i = 0

abstract/iterator-test.js

@@ -175,6 +175,7 @@ module.exports.tearDown = function (test, testCommon) {
 }
 
 module.exports.all = function (leveldown, test, testCommon) {
+  testCommon = testCommon || require('../testCommon')
   module.exports.setUp(leveldown, test, testCommon)
   module.exports.args(test)
   module.exports.sequence(test)

abstract/open-test.js

@@ -114,6 +114,7 @@ module.exports.tearDown = function (test, testCommon) {
 }
 
 module.exports.all = function (leveldown, test, testCommon) {
+  testCommon = testCommon || require('../testCommon')
   module.exports.setUp(test, testCommon)
   module.exports.args(leveldown, test, testCommon)
   module.exports.open(leveldown, test, testCommon)

abstract/put-get-del-test.js

@@ -1,5 +1,6 @@
 var db
-var verifyNotFoundError = require('./util').verifyNotFoundError
+const verifyNotFoundError = require('./util').verifyNotFoundError
+const testBuffer = Buffer.from('testbuffer')
 
 function makeGetDelErrorTests (test, type, key, expectedError) {
   test('test get() with ' + type + ' causes error', function (t) {
@@ -104,7 +105,7 @@ module.exports.errorKeys = function (test) {
   makeErrorKeyTest(test, 'empty Array key', [], /key cannot be an empty String/)
 }
 
-module.exports.nonErrorKeys = function (test, testBuffer) {
+module.exports.nonErrorKeys = function (test) {
   // valid falsey keys
   makePutGetDelSuccessfulTest(test, '`false` key', false, 'foo false')
   makePutGetDelSuccessfulTest(test, '`0` key', 0, 'foo 0')
@@ -130,7 +131,7 @@ module.exports.nonErrorKeys = function (test, testBuffer) {
 module.exports.errorValues = function () {
 }
 
-module.exports.nonErrorValues = function (test, testBuffer) {
+module.exports.nonErrorValues = function (test) {
   // valid falsey values
   makePutGetDelSuccessfulTest(test, '`false` value', 'foo false', false)
   makePutGetDelSuccessfulTest(test, '`0` value', 'foo 0', 0)
@@ -164,11 +165,12 @@ module.exports.tearDown = function (test, testCommon) {
   })
 }
 
-module.exports.all = function (leveldown, test, testCommon, testBuffer) {
+module.exports.all = function (leveldown, test, testCommon) {
+  testCommon = testCommon || require('../testCommon')
   module.exports.setUp(leveldown, test, testCommon)
   module.exports.errorKeys(test)
-  module.exports.nonErrorKeys(test, testBuffer)
+  module.exports.nonErrorKeys(test)
   module.exports.errorValues(test)
-  module.exports.nonErrorValues(test, testBuffer)
+  module.exports.nonErrorValues(test)
   module.exports.tearDown(test, testCommon)
 }

abstract/put-test.js

@@ -127,6 +127,7 @@ module.exports.tearDown = function (test, testCommon) {
 }
 
 module.exports.all = function (leveldown, test, testCommon) {
+  testCommon = testCommon || require('../testCommon')
   module.exports.setUp(leveldown, test, testCommon)
   module.exports.args(test)
   module.exports.put(test)